Skip to content

ci: publish Rust crate releases - #19

Merged
qartik merged 2 commits into
mainfrom
codex-setup-package-publishing
Sep 24, 2026
Merged

qartik merged 2 commits into
mainfrom
codex-setup-package-publishing

Conversation

@qartik

@qartik qartik commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Summary

  • publish qir-formatter to crates.io when a GitHub Release is created
  • verify the locked Cargo package before publishing
  • add crates.io discovery metadata and document the published Rust dependency
  • preserve the existing PyPI wheel, sdist, and publishing flow

Validation

  • cargo publish --dry-run --locked --allow-dirty
  • tests from the packaged crate: 17 unit tests and 1 doctest
  • uv run src/scripts/ci_checks.sh: Clippy, formatting, ty, 17 Rust tests, 1 doctest, and 38 Python tests
  • local cp310-abi3 wheel and sdist builds
  • clean installation of the wheel on Python 3.14, followed by all 38 compatibility tests
  • abi3audit --strict verifies the extension's Python 3.10 stable-ABI baseline
  • twine check --strict and uv publish --dry-run accept the wheel and sdist upload set
  • downstream Rust consumer build using the documented dependency alias

The release-only wheel matrix cannot run on this pull request. Its publish job depends on every Linux, macOS, Windows, and sdist build-and-install test, so PyPI publishing is blocked if any target fails rather than uploading a partial release.

@qartik
qartik requested review from chesterwringe and qfreewilll and a balanced review from Copilot September 24, 2026 13:31
@qartik qartik self-assigned this Sep 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The documented installation command does not create the dependency alias required by the Rust usage example.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

Publishes the Rust crate to crates.io while preserving PyPI releases.

Changes:

  • Adds crates.io publishing and package verification.
  • Adds crate discovery metadata.
  • Documents Rust installation and dependency aliasing.
File Description
.github/​workflows/​release.yml Publishes releases to crates.io.
Cargo.toml Adds crates.io metadata.
README.md Documents Rust installation and usage.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread README.md Resolved
@qartik
qartik marked this pull request as ready for review September 24, 2026 13:54
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T13:57:28.420209Z 5848725 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@qartik
qartik merged commit 1237417 into main Sep 24, 2026
4 of 5 checks passed
@qartik
qartik deleted the codex-setup-package-publishing branch September 24, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants