Repository navigation
perf: speed up shot parsing with early tag filtering - #16
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Optimizes USER-tag parsing while preserving existing formatting behavior.
Changes:
- Filters non-USER tags before parsing.
- Uses
partition()to parse type and tag without list allocation.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
chesterwringe
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimized
emit_values_in_shot()to skip non-USER tags efficiently using early filtering and idiomatic string operations.Changes
startswith()prefix check to quickly skip non-USER tags without string splittingsplit()withpartition()for parsing USER tags (more efficient)This improves performance when processing shots with many non-USER tags (MEAS, METRICS, EXIT), as only USER-tagged items now undergo string parsing.
Testing
All 33 existing tests pass, covering: