Repository navigation
feat: Add implement_ops and encode pass to the toy_k2 architecture
#407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PabloAndresCQ
wants to merge
27
commits into
feat/toyk2_logicals
Choose a base branch
from
feat/toyk2_encode
base: feat/toyk2_logicals
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,305
−15
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
005ea03
Completed prototype with design intent. This has not been tested yet.
PabloAndresCQ 7f49fbf
Included prep_zero_plus_ft and used it to implement h_dynq
PabloAndresCQ d26c01d
Remove qed_policy call on measure_z_all
PabloAndresCQ 5d92d29
fix errors to compile
hsemenenko c256850
Simplified code
PabloAndresCQ f790638
add test
hsemenenko befb637
fix return types
hsemenenko 5226d45
fix release addr
hsemenenko 306d071
add dynq cx test
hsemenenko 54ad453
Some additional fixes
PabloAndresCQ 8773fbd
Added more implement tests
PabloAndresCQ acfba79
Changed name allocate_block to allocate_block_id
PabloAndresCQ ea08e9f
Added encode tests
PabloAndresCQ 4b87504
Replaced missing decode_qubit_type op with decode_qubit_measurement
PabloAndresCQ 08b9b3c
Renamed measure_z as project_z and fixed issues related to qubit cons…
PabloAndresCQ 8c993cc
Changed order of outputs of borrow
PabloAndresCQ 672aee3
Fixed bug on _s_dynq and _t_dynq. Fixed _measure_all_z's signature to…
PabloAndresCQ c62c016
Use explicit test on the dictionary and fix bugs in the test that wer…
PabloAndresCQ 4652d4e
Removed unnecessary test and changed a skip mark to xfail
PabloAndresCQ 9387c3e
Use decorator @_register_op_replacement to remove boilerplate
PabloAndresCQ 27d95e9
Dropped tests on implement_ops for _dynq ops
PabloAndresCQ 1b05312
Now using _ToyK2Options rather than ToyK2EncoderParams, following #465
PabloAndresCQ ff75f9a
Dropping logical API means we have to support measure_z_dynq as a HUG…
PabloAndresCQ 6d96173
Bumped number of extension ops in tests
PabloAndresCQ 38cac1f
refactor(toyk2): encode state using borrow-array take/put not Option …
acl-cqc a52e823
Added more insightful effect annotations, per Max's request
PabloAndresCQ 7fd91c8
Implement ops now uses RUS zero state prep, rather than expect it'll …
PabloAndresCQ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to
_dynqops being dropped from the logical API (see latest changes in #326), we can no longer havemeasure_z_dynqas a compound op of logicals (it used to compose the bindings ofproject_z_dynqandfree_dynq. So, I'm adding it as a new extension op, since we need to compiletket2.ops.MeasureFreeto it.