Updating Orders should fail if it causes insufficient margin #8553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosueNina
force-pushed
the
bug-5964-updating-stop-orders-should-fail
branch
from
93ab38f to
a6ac4a9
Compare
|
|
||
| if (!hasSufficientBuyingPowerResult.IsSufficient) | ||
| { | ||
| var errorMessage = $@"Order Error: id: [{order.Id}], Insufficient buying power to complete order, Reason: {hasSufficientBuyingPowerResult.Reason}."; |
There was a problem hiding this comment.
Some order errors only include the order ID, and it is -10.
It would be helpful to add the Symbol and the Order Time. Perhaps order.ToString()...
JosueNina
changed the title
JosueNina
force-pushed
the
bug-5964-updating-stop-orders-should-fail
branch
from
71dbab6 to
bdb519e
Compare
JosueNina
changed the title
JosueNina
force-pushed
the
bug-5964-updating-stop-orders-should-fail
branch
from
88d48ff to
de6c6f2
Compare
4 tasks
|
Follow up issue: #8567 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added validation to ensure update orders are rejected when updated without sufficient margin.
Related Issue
Closes #5964
Motivation and Context
This change introduces validation to ensure that update orders are rejected when updated without sufficient margin, as stated in the description.
Requires Documentation Change
No.
How Has This Been Tested?
Tested using regression tests to verify that update orders are rejected when updated without sufficient margin. Additionally, ensured that existing functionality remains unaffected.
Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>