Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collective2 - No index option #8494

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

JosueNina
Copy link
Contributor

@JosueNina JosueNina commented Jan 3, 2025

Description

This PR adds support for IndexOptions in Collective2 signal export

Related Issue

Closes #8487

Motivation and Context

This change was required to fix a bug where Collective2 did not support IndexOptions, as indicated in the ConvertTypeOfSymbol method. The fix extends compatibility to handle IndexOptions correctly.

Requires Documentation Change

No documentation changes are required.

How Has This Been Tested?

The changes were tested using regression tests and unit tests to ensure IndexOptions are correctly exported

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@JosueNina JosueNina force-pushed the bug-8487-no-index-option branch from 71d0fed to bb6f862 Compare January 3, 2025 21:56
@JosueNina JosueNina force-pushed the bug-8487-no-index-option branch from bb6f862 to e8164fc Compare January 3, 2025 21:57
@JosueNina JosueNina changed the title WIP: Collective2 - No index option Collective2 - No index option Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collective2 Supports Index Options
1 participant