Add filesystem abstraction #251
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The REST API has been updated to allow reading directly from fsspec-supported filesystems. The new workflow is to first generate metadata on the server via a GET to the '/document' endpoint. If the metadata references a document on a fsspec-supported path, then we go straight to the 'chats' endpoint. Otherwise, the workflow is as before and we must upload the document to the server via a POST to the '/document' endpoint.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@nenb Just checking in to say that I didn't forget about this. I'll review as soon as I find the time. |
|
@pmeier No problem. And just a reminder that this isn't really a PR, just a PoC (you asked me to open as a PR in #233 for ease-of-viewing), and so don't feel that you need to analyse too carefully. If there are any features that you think have potential, I am happy to pull these out as separate PRs. |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP