Fix optimization_preferences used in generate_ai_pass_manager method
#130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjuan
requested review from
d-kremer,
victor-villar,
jesus-talavera-ibm and
y4izus
as code owners
victor-villar
previously approved these changes
Nov 15, 2024
jesus-talavera-ibm
previously approved these changes
Nov 15, 2024
cbjuan
dismissed stale reviews from jesus-talavera-ibm and victor-villar
via
4de764b
|
Please add |
victor-villar
requested changes
Nov 15, 2024
| "cnot_layers", | ||
| "n_cnots", | ||
| "layers", | ||
| "n_gates", | ||
| ), | ||
| ], | ||
| qiskit_transpile_options: dict = {}, |
There was a problem hiding this comment.
We need to make this default None or we risk changing the default dict for next calls.
victor-villar
previously approved these changes
Nov 15, 2024
victor-villar
approved these changes
Nov 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #129
Details and comments
Also, this PR ensures Runtime is installed for the local mode dependencies.