Skip to content

Conversation

@trvto
Copy link
Collaborator

@trvto trvto commented Jul 1, 2025

Implementation of a "simulation" benchmark solving the free fermion problem


return score, end_time_measurement(start)

def save(self, path, iter_count) -> None:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, not needed, right?

from src.utils import start_time_measurement, end_time_measurement


class FreeFermion(Simulation):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some logging during the simulation would help users and facilitate debugging/evaluation if needed.

@trvto
Copy link
Collaborator Author

trvto commented Jul 9, 2025

@Marvmann I have added/removed all the things we discussed with regards to the benchmark structure (see the latest commits). Etienne would like to make some minor changes to the benchmark itself and double check the benchmark code for bugs. When that is done I will publish this draft.

@trvto trvto marked this pull request as ready for review July 15, 2025 15:43
@trvto trvto requested review from aluckow, drelu and philross as code owners July 15, 2025 15:43
@trvto trvto requested a review from Marvmann July 15, 2025 15:44
@trvto
Copy link
Collaborator Author

trvto commented Jul 15, 2025

Okay all the updates are in now. One question remains: It appears that all applications do need to implement the save method. (It was suggested this could be left out). My current implementation doesn't do anything and seems to work. If it should be done properly please let me know

@Marvmann Marvmann changed the base branch from main to dev July 22, 2025 08:08
@Marvmann Marvmann merged commit 764feb0 into dev Jul 22, 2025
4 checks passed
@Marvmann Marvmann mentioned this pull request Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants