-
Notifications
You must be signed in to change notification settings - Fork 27
First implementation free fermion benchmark #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/modules/applications/simulation/free_fermion/free_fermion.py
Outdated
Show resolved
Hide resolved
|
|
||
| return score, end_time_measurement(start) | ||
|
|
||
| def save(self, path, iter_count) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, not needed, right?
| from src.utils import start_time_measurement, end_time_measurement | ||
|
|
||
|
|
||
| class FreeFermion(Simulation): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some logging during the simulation would help users and facilitate debugging/evaluation if needed.
…k' into free-fermion-simulation-benchmark
|
@Marvmann I have added/removed all the things we discussed with regards to the benchmark structure (see the latest commits). Etienne would like to make some minor changes to the benchmark itself and double check the benchmark code for bugs. When that is done I will publish this draft. |
|
Okay all the updates are in now. One question remains: It appears that all applications do need to implement the |
Implementation of a "simulation" benchmark solving the free fermion problem