Repository navigation
Make enterprise arithmetic commit explicit - #4
Conversation
There was a problem hiding this comment.
Sorry @EmergentMonk, you've used your own review budget of 250,000 diff characters for the last 7 days.
You can request another review in 2 days and 9 hours by commenting @sourcery-ai review. Upgrade to get a review now.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer's GuideChanges the calculator from implicit recalculation to an explicit enterprise-commit workflow, updates the UI and README to explain and promote it, and adds coverage for deferred execution and failure-state cleanup. Sequence diagram for explicit enterprise arithmetic commitsequenceDiagram
actor User
participant Calculator as Calculator UI
participant Form as Form submit handler
participant Report as Report
User->>Calculator: Edit operand, operation, or style
Calculator-->>User: Stage inputs locally
Note over Calculator: No change handlers execute arithmetic
User->>Form: Submit COMMIT ENTERPRISE ARITHMETIC
Form->>Report: clearReport()
Form->>Form: calculate()
alt valid arithmetic
Form-->>Report: Display result
else division by zero or other failure
Form-->>Report: Display error with stale output cleared
end
Flow diagram for staged calculator request and explicit commitflowchart TD
A[Calculator loads] --> B["clearReport()"]
B --> C[User edits calculator inputs]
C --> D[Request remains staged]
D --> E{Form submitted}
E -->|No| D
E -->|Yes| F["calculate()"]
F --> G{Arithmetic succeeds}
G -->|Yes| H[Display result]
G -->|No| I[Clear stale report and display error]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c597d57491
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex please review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Makes COMMIT ENTERPRISE ARITHMETIC the actual execution trigger for the HERESY API Calculator and promotes the live GitHub Pages site in the README.
Behavior change
Previously, changing an operand, operation, or interface style recalculated immediately, so pressing the large enterprise button often appeared to do nothing because the work had already happened.
Now:
The UI now says explicitly that inputs are staged locally until enterprise arithmetic is committed.
Documentation
The README now prominently links the live calculator:
https://qsolkcb.github.io/HERESY-API/
It also documents the staged-request / explicit-commit behavior.
Regression coverage
9 × 4and proves the result remains blank until form submission36The joke now requires actual management approval before arithmetic can proceed.
Summary by Sourcery
Make enterprise arithmetic execute only after users explicitly commit a staged calculator request.
New Features:
Bug Fixes:
Enhancements:
Documentation:
Tests: