fix: fix queue timeout variable and set default in tests of 10 seconds #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there is a bug in the queue timeout code. "roborock.exceptions.RoborockTimeout: id=0 Timeout after 4 seconds" as it doesn't seem to respect constructor arguments. Edit: Fixed the constructors to stop propagating the queue timeout everywhere and instead just set it in the 3 clients impls |
allenporter
changed the title
allenporter
force-pushed
the
test-timeout
branch
from
30a5e98 to
b52227e
Compare
Lash-L
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the class hierarchy for queue_timeout so that it is only set in the base classes. Right now it is passed up through the constructors, but sometimes uses the default arguments and get overwritten. This is an example of the problems with having multiple inheritance.
Issue #228
Update the tests to set a timeout of 10 up from 4 to see if it helps the tests be more resilient to slowness.