Skip to content

Conversation

Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Nov 10, 2024

No description provided.

@humbertogontijo
Copy link
Collaborator

Wouldn't be better to return all parsed data? Something like get_parsed_map

@Lash-L
Copy link
Collaborator Author

Lash-L commented Nov 11, 2024

Wouldn't be better to return all parsed data? Something like get_parsed_map

@humbertogontijo

Eh - maybe? But after talking with Piotr for the map card, he really just needs the calibration points.

Calibration points are already in a dictionary and serializable. The entire parsed map is not, which I'm afraid could cause some problems with Vacuum: Send Command

I think I would prefer to leave it like this and if a use case pops up, I will add a second one for get parsed map and think through a solution

@humbertogontijo
Copy link
Collaborator

Alright

@Lash-L Lash-L merged commit c8507ef into main Nov 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants