-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ Add MediaChannel
and fix ForumChannel
flags
#2641
base: master
Are you sure you want to change the base?
feat: ✨ Add MediaChannel
and fix ForumChannel
flags
#2641
Conversation
MediaChannel
MediaChannel
and fix ForumChannel
flags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure but afaik I the channel class you also have a model for the base type which has type: literal channel type blah. Is that perhaps missing?
@property
def type(self) -> ChannelType:
"""The channel's Discord type."""
return try_enum(ChannelType, self._type) |
It's redundant if the classes inherit from _TextChannel. |
0d73cf7
to
bb8bc7b
Compare
Undid it then |
6b274da
to
38b5f3e
Compare
Signed-off-by: Dorukyum <[email protected]>
c2a9853
to
0b3f756
Compare
Summary
Fix #2637
Fix #2640
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.