-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development #395
Open
tapegoji
wants to merge
62
commits into
PySpice-org:devel
Choose a base branch
from
tapegoji:development
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Development #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # PySpice/Spice/NgSpice/Shared.py
# Conflicts: # .github/workflows/pyspice-test.yml
# Conflicts: # .github/workflows/pyspice-test.yml
# Conflicts: # PySpice/Spice/NgSpice/Simulator.py
# Conflicts: # PySpice/Spice/NgSpice/SimulationType.py # PySpice/Spice/NgSpice/Simulator.py
…und_thread_running at 0x000000004999c720>, trying to convert the result back to C:
therms -> terms
I saw this issue but I didn't thought it would affect me... well IT DID! See PySpice-org#313 or PySpice-org#328 truly a problem
…nd added a new add_esr methods to enhance convergence
… in buck converter example
…itions. This is common in spice netlist node names.
…itions and add new diode and transistor model files
…mples and comment out lowercase file check in run-examples script
…essions. removed the 'params:' id from when it's parsing the spice file
…ng in parser. change the name from basex to base
… it should match +in and -in or +_in or -_in for the ID
…imulation is still successful.
…ix for identifiers for ID in a netlist. in xspice %v or %vd and etc is common.
…error on aborted simulations; update input clipper model limit range
…brary parsing but keep going. if you can load a library, you should be able to load the rest of the libraries.
…ompatibility with skidl
… a folder find the parnt folder instead. this way the rest of the code remains unchanged and it does not give error add cleanup script for temporary files
…ackward compatibility
…w subcircuits have pins.
…nd simulation when we halt and resume we get an simulationa intterupted in stdout. This should not cause the simulation to break.
…sing background feature in ngspice
…d upgrade action versions
…e tests to improve clarity and functionality
…name in _node assignment
…SpiceInclude class adding files to test skywater pdk
…lude paths in HighLevelParser this is a fix for the issue when there is an .include in a library. a fix in
…ple_nand.py for proper library loading
…when dealing with nodes names and other names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Fabrice,
All the changes are needed to be able to run all the examples and new ones. Please let me know if you still want to break the changes.