Fix cross-compilation from unix to windows #923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
fix-cross-compile
branch
from
bf674da to
74f399a
Compare
kngwyu
reviewed
May 13, 2020
|
I did notice this issue when trying to implement the |
|
👍 agreed, I've decided I'm certain that this fix is correct. I'll rebase and finish this PR (and also add hard-coded windows cross-compile settings) after #1095 lands. |
davidhewitt
force-pushed
the
fix-cross-compile
branch
from
74f399a to
3fa1639
Compare
|
As discussed, I've rebased this PR and it should now be ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
build.rsfunctions slightly incorrectly for cross-compilation.If I understand correctly, the build script is always compiled for the host platform, so we can't actually use
#[cfg(target_os = "macos")]to set link args, for example. Instead we need to check theCARGO_CFG_TARGET_OSenv var which is set during build script execution.This might fix #666. I want to work with feedback from users before we merge this PR.