Introspection: Declare INPUT_TYPE and OUTPUT_TYPE nearly everywhere #5637
+423
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slice and lists are not done yet, it should be the focus of a specific MR (non-trivial support of the bytes special case)
davidhewitt
approved these changes
Nov 21, 2025
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Super, this feels like it's really come together now!
| #[cfg(feature = "experimental-inspect")] | ||
| const INPUT_TYPE: crate::inspect::TypeHint = crate::inspect::TypeHint::subscript( | ||
| &PyTuple::TYPE_HINT, | ||
| &[$($T::INPUT_TYPE ),+] |
Member
There was a problem hiding this comment.
👍 It's really nice that this works!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
CI failed because of a 502 error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slice and lists are not done yet, it should be the focus of a specific MR (non-trivial support of the bytes special case)