add API to set rpath for libpython from build scripts #5624
+43
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible replacement for #5622
This PR adds
pyo3_build_config::add_libpython_rpath_link_args(), to set rpath to libpython from crate build scripts.The idea here is that using
rpathshould make it trivial to link to the correct libpython; we already haveadd_python_framework_link_argswhich is doing the same thing (and should probably merge with this proposed function).I remove
pyo3-ffi-check's use of theextension-modulefeature and use this API instead, which should demonstrate if it works...