Skip to content

readme/faq: document rlib crate type better #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

davidhewitt
Copy link
Member

@davidhewitt davidhewitt commented Jan 3, 2021

This simplifies the documentation around cdylib and rlib crate types in the readme and includes a similar note in the FAQ as #1336 .

I think that rlib crate type is the best solution - I tested manually and this works great for me locally.

I think the issue described in #1336 (comment) is likely a result of some static linking, because the error is talking about relocating a symbol incorrectly. This is probably prevented by #1347.

Closes #1321
Closes #1336

@kngwyu
Copy link
Member

kngwyu commented Jan 4, 2021

Thanks.
Could you please rebuild this PR on #1336 to give credit to the original author?
E.g., gh pr pull command would work nicely.
EDITED: No such command. I meant gh pr checkout.

@davidhewitt
Copy link
Member Author

👍 will do so when I get a chance

@davidhewitt davidhewitt force-pushed the integration-tests-faq branch from 53e419f to c1c4a5f Compare January 6, 2021 06:55
@davidhewitt davidhewitt merged commit c8172e9 into PyO3:master Jan 6, 2021
@davidhewitt davidhewitt deleted the integration-tests-faq branch August 10, 2021 07:20
@davidhewitt davidhewitt restored the integration-tests-faq branch August 10, 2021 07:20
@davidhewitt davidhewitt deleted the integration-tests-faq branch August 10, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests can't find crate
2 participants