test: quick-update assertions track fit.png (fit_quick.png removed) - #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workspace follow-up to the fit_quick.png removal (PyAutoLabs/PyAutoLens#680): quick updates now write the normal
fit.pngfit subplot, so the three visualization-jit scripts that assertedfit_quick.pngwas produced now assertfit.pnginstead. Comments note that quick updates run on the main thread by default, so the KeyError regression these scripts guard would crash the search rather than be swallowed — the PNG assertion is a secondary signal.Upstream PR
Scripts Changed
scripts/imaging/visualization/modeling_visualization_jit.py— assertfit.pngproduced; comments updated. Validated end-to-end under the library branch: the quick update fired and wrotefit.png.scripts/interferometer/visualization/modeling_visualization_jit.py— assertfit.pngproduced; comments updated.scripts/point_source/visualization/modeling_visualization_jit.py— assertfit.pngproduced; comments updated.Interferometer/point quick paths are covered at the plotter level by new unit tests in PyAutoLens#682 (
test_autolens/*/model/test_plotter_*.py).Shipped under human-authorized Heart-RED override; RED reason (verbatim, unrelated nightly):
release validation FAILED (stage integrate).Generated by the PyAutoLabs agent workflow.