docs: point-source solved-variant guides (phase 4 of #657) - #425
Merged
Conversation
…commendation (phase 4 of PyAutoLens#657) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 4 (guides/docs) of the point-source solved-likelihood series (PyAutoLens#657; library API merged in phase 2 via PyAutoArray#414 / PyAutoGalaxy#531 / PyAutoLens#659). Documents the full likelihood-option matrix — pairing scheme × centre treatment (free vs analytically solved) — across the workspace guides:
al.ps.PointSolved/SolvedCentrevariant matrix, the tensor-weighted source-plane chi-squared (Lombardi 2024, arXiv:2406.15280 §5.1) and itsweighting = "jacobian" | "magnification"conventions, the solved flux/time-delay fits, the missing-image-penalty status, and a runnable solved-centre demo case.cluster/likelihood_function.pythatFitPositionsSource(profile=None)uses a back-traced barycenter (it raises) — the real centre-free option isal.ps.PointSolved+FitPositionsSourceSolved.FitPositionsSourceSolved, validate with the image-plane chi-squared. Demonstrated defaults in the modeling scripts are unchanged (prose-only recommendation).Scripts Changed
scripts/guides/point_source_pairing.py— second-axis sections (solved-variant matrix, tensor-vs-scalar weighting, solved fluxes/delays, missing-image penalty, cluster recommendation) + runnable Case 4 solved-centre demoscripts/point_source/fit.py—__Solved Source Centre__section with a runnableFitPositionsSourceSolvedfit; defaults note (FitPointDataset→FitPositionsImagePairvsAnalysisPoint→FitPositionsImagePairRepeat); solved flux/time-delay pointersscripts/cluster/likelihood_function.py—profile=Nonefalse claim replaced with the real solved-centre option; when-to-use advice updated to the solved search-stage recommendation; header notes the*Solvedsiblingsscripts/point_source/features/fluxes.py—__Analytic Flux (Solved)__compose-only section (fit_flux_cls=al.FitFluxesSolved; model drops from N=8 to N=5)scripts/point_source/features/time_delays.py—__Analytic Reference Time (Solved)__compose-only section (fit_time_delays_cls=al.FitTimeDelaysSolved)scripts/point_source/modeling.py,scripts/cluster/modeling.py,scripts/cluster/start_here.py— short centre-free mentions where model composition is discussedscripts/cluster/lenstool/modeling.py— Lenstool-mapping table note:FitPositionsSourceSolvedwithweighting="magnification"matches Lenstool's scalar µ² conventionNotebooks regenerated for all nine touched scripts; generator artifacts (
workspace_index.json,llms-full.txt,.script_sizes.json) refreshed.Upstream PR
PyAutoLabs/PyAutoLens#659 (MERGED 2026-07-27)
Test Plan
point_source/fit.pyplain;features/fluxes.py+features/time_delays.pyunder the smoke profile) — all pass; solved centre recovers the true (0.07, 0.07)check_sizes.shclean; notebook regeneration is 1:1 with touched scripts, no stray diffsGenerated by the PyAutoLabs agent workflow.