fix: multi-wavelength modeling green (auto-simulate + SersicCore effective_radius=0) - #306
Merged
Merged
Conversation
… fix) - Add the missing dataset auto-simulate block to multi/features/wavelength_dependence/modeling.py (mirrors multi/modeling.py), so the script simulates its dataset on first run instead of FileNotFoundError. - Drop the NEEDS_FIX marker from config/build/no_run.yaml. The marker's stated "FitException" was actually a SersicCore ZeroDivisionError on effective_radius=0 (test-mode median of the wavelength*m+c relation), fixed upstream in PyAutoGalaxy#515; with that fix + auto-simulate the script runs green from clean. - Regenerate the notebook. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
multi/features/wavelength_dependence/modelingrunnable green (wasNEEDS_FIX). Two issues combined:SersicCoreZeroDivisionError oneffective_radius=0— the marker's stated "FitException" was really this; the model'seffective_radius = wavelength*m + crelation (symmetric-about-0m,cpriors) giveseffective_radius=0at the test-mode median. Fixed upstream in PyAutoGalaxy#515.multi/modeling.py, this script had no dataset auto-simulation, so itFileNotFoundErrored on a fresh checkout. Added the standardshould_simulate → subprocess simulator.pyblock.With both, the script runs green from a clean state under the CI smoke env.
Scripts Changed
scripts/multi/features/wavelength_dependence/modeling.py— add dataset auto-simulate block (mirrorsmulti/modeling.py)config/build/no_run.yaml— drop themulti/features/wavelength_dependence/modelingNEEDS_FIX markernotebooks/multi/features/wavelength_dependence/modeling.ipynb— regeneratedUpstream PR
PyAutoLabs/PyAutoGalaxy#515
Test Plan
modeling.pyruns green from clean (auto-simulates then models; EXIT 0) underPYAUTO_DISABLE_JAX=1 TEST_MODE=2 SMALL_DATASETS=1run_smoke.py— 9/9 passed (against the fixed PyAutoGalaxy branch)Generated by the PyAutoLabs agent workflow.