ci: drop the vestigial jax<0.7 pin from smoke_install.sh - #107
Merged
Conversation
This repo's install epilogue carried the same stale line as autolens_workspace_test, where it was found and diagnosed (autolens_workspace_test#266). `pip install "jax<0.7" "jaxlib<0.7"` was added there in autolens_workspace_test#82 solely to keep `tensorflow-probability==0.25.0` importable, since `tfp.substrates.jax` referenced `jax.interpreters.xla.pytype_aval_mappings`, removed in JAX 0.7.0. autolens_workspace_test#184 deleted that dependency when the stack moved to tfp-nightly (pinned by `PyAutoArray[optional]`). The pin outlived what it protected. It is not merely inert. jax is a base dependency of autonerves (jax>=0.7.0,<0.12.0, PyAutoLens#702), so the preceding line already installs a conforming jax; the pin then downgraded it to 0.6.2 — unsupported by the stack — and only the following `[optional]` re-resolution repaired it. The install was correct by line ordering, not by constraint. Remove the pin, leave a comment recording the trail (issue references qualified with their repo, since they are autolens_workspace_test numbers), and assert the resolved jax version at the end of the script so the outcome is checked rather than inferred from a green run. autocti_workspace_test and autofit_workspace_test were also checked; neither carries a jax pin, so no change is needed there. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KMknTjH347FBZUE82nNEby
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This repo's install epilogue carried the same stale line as
autolens_workspace_test, where it was found and diagnosed — see PyAutoLabs/autolens_workspace_test#266 and its companion PR PyAutoLabs/autolens_workspace_test#268..github/scripts/smoke_install.shpinnedjax<0.7 jaxlib<0.7. That pin was added in autolens_workspace_test#82 for exactly one reason: keepingtensorflow-probability==0.25.0importable, sincetfp.substrates.jaxreferencedjax.interpreters.xla.pytype_aval_mappings, removed in JAX 0.7.0. autolens_workspace_test#184 then deleted that dependency when the stack moved totfp-nightly(pinned byPyAutoArray[optional]). The pin outlived what it protected.It was not merely inert.
jaxis a base dependency ofautonerves(jax>=0.7.0,<0.12.0, PyAutoLens#702), so the preceding line already installed a conforming jax; the pin then downgraded it to 0.6.2 — unsupported by the stack — and only the following[optional]re-resolution repaired it. The install was correct by line ordering, not by constraint, and a reordering would have dropped the smoke suite onto jax 0.6.2 silently.This removes the pin, leaves a comment recording the trail, and asserts the resolved jax version at the end of the script so the outcome is checked rather than inferred from a green run.
Scripts Changed
.github/scripts/smoke_install.sh— removedpip install "jax<0.7" "jaxlib<0.7"; replaced with a comment recording why no jax pin belongs here (issue references qualified asautolens_workspace_test#82/#184, since bare numbers would resolve to unrelated issues in this repo); appended a post-install assertion that the resolved jax falls in[0.7.0, 0.12.0), printing the version to the CI log.No workspace
scripts/ornotebooks/are touched — this is CI install configuration only.Test Plan
resolved jax <version>with a version in[0.7.0, 0.12.0)Validation already performed
bash -nclean on the modified script.0.7.0/0.9.0/0.10.2/0.11.4pass;0.6.2/0.12.0/1.0.0fail.jax:0.10.2printsresolved jax 0.10.2and exits 0;0.6.2and0.12.0exit 1 with the explanatory message. Withset -eat the top of the script, that aborts the install step.PyAutoHeart/.github/workflows/smoke-tests.ymlusesactions/setup-python@v5onubuntu-latest, sopythonis on PATH.Implementation notes
packaging.version, avoiding a dependency this epilogue does not otherwise declare.import jaxis deliberately unguarded: this workflow runs onubuntu-latest, whereautonerves' platform marker always installs jax, so an absent jax is itself a failure worth catching.Sibling repos
autocti_workspace_testandautofit_workspace_testwere also checked; neither carries a jax pin, so no change is needed there.Generated by the PyAutoLabs agent workflow.
Generated by Claude Code