docs: retire deleted TransformerNUFFTPyNUFFT from interferometer docs - #225
Merged
Merged
Conversation
PyAutoArray#475 deleted TransformerNUFFTPyNUFFT, but these scripts still advertised it as an available 'non-JAX fallback'. autogalaxy_workspace is the sibling of autolens_workspace, fixed in autolens_workspace#497; it was never swept. Wording mirrors #497, adapted to the galaxy context. Also corrects scripts/interferometer/start_here.py, which still claimed TransformerNUFFT 'is not JAX-traceable' and called nufftax 'a research path' -- both stale since nufftax shipped as the default backend. The Intel-macOS fallback is now stated accurately: use TransformerDFT (exact, pure-numpy, O(N_vis x N_pix)) where JAX has no wheels. notebooks/ regenerated via generate.py. markdown/ deliberately NOT regenerated: generate_markdown.py executes curated scripts for real and its documented policy is 'manual / at-release, only when a curated script changes -- never per-commit'. Three curated pages (start_here, interferometer/start_here, interferometer/simulator) are affected and will refresh at the next release. Refs #224 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JEXzQpvG3QNUdTh6tZcaAE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retires
TransformerNUFFTPyNUFFT— deleted by PyAutoLabs/PyAutoArray#475 — from this workspace's interferometer docs.Why this repo was missed: the removal task scoped its workspace tier to
autolens_workspace(fixed in PyAutoLabs/autolens_workspace#497) andautolens_workspace_test.autogalaxy_workspaceis the direct sibling and was never swept. Wording here mirrors #497, adapted to the galaxy context.Scripts Changed
scripts/interferometer/start_here.pyTransformerNUFFTPyNUFFTfallback line; correct the stale claim thatTransformerNUFFT"is not JAX-traceable" and thatnufftaxis "a research path"scripts/interferometer/simulator.pyscripts/interferometer/features/linear_light_profiles/modeling.pyscripts/guides/using_jax.pystart_here.pynufftaxnotebooks/**regenerated viagenerate.py autogalaxy; never hand-edited.workspace_index.jsonchanged only because a cross-reference toautolens_workspace_test/scripts/interferometer/nufft.pywas removed with its sentence.The stale claim worth flagging
scripts/interferometer/start_here.pystill told usersTransformerNUFFT"is not JAX-traceable" and thatnufftaxwas a "research path tracking that". Both predate nufftax shipping as the default backend. The autolens sibling has said the opposite since #497 — the two workspaces contradicted each other.Intel macOS
Where a genuine non-JAX fallback is needed the docs now name
TransformerDFT(exact, pure-numpy,O(N_vis × N_pix)), matching the decision recorded in the removal task:jaxlib's last Intel-macOS wheel is 0.4.38 and there is no sdist, so those users keep DFT only.markdown/deliberately NOT regeneratedgenerate_markdown.pyexecutes curated scripts for real, and its own documented policy is "manual / at-release, only when a curated script changes — never per-commit." Three curated pages are affected (start_here,interferometer/start_here,interferometer/simulator) and will refresh at the next release. They still contain the stale text until then.Validation
scripts/check_sizes.sh:OK — no changed script shrank >50%.paper/untouched (published JOSS record) — confirmed bygit diff --stat.Note for the reviewer
Heart was RED (
release validation FAILED, unrelated) at PR-open; the human explicitly authorized push + PR-open. Merge remains gated.Refs #224