Skip to content

ci: adopt the notebook SystemExit(0) skip-guard classifier (PyAutoHands#198) #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jammy2211 merged 1 commit into from
Jul 25, 2026
Merged

ci: adopt the notebook SystemExit(0) skip-guard classifier (PyAutoHands#198) #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/scripts/run_smoke.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@
sys.path.insert(0, str(WORKSPACE.parent / "PyAutoHands" / "autohands"))
from env_config import build_env_for_script, load_env_config

from build_util import is_clean_skip_exit # PyAutoHands/autohands on PYTHONPATH


def load_lines(path: Path) -> list[str]:
if not path.exists():
Expand Down Expand Up @@ -167,6 +169,10 @@ def run_notebook(nb_rel: str, cfg: dict | None) -> tuple[str, int, float, str]:
return nb_rel, 1, 0.0, f"Notebook not found: {nb_path}\n"

rc, output = execute_notebook(nb_path, env)
if rc != 0 and is_clean_skip_exit(output):
# Optional-dependency skip guard (`sys.exit(0)`): a clean exit 0 as a
# `.py` script, so the notebook form is a PASS too (PyAutoHands#198).
rc = 0
if rc == 0:
return nb_rel, 0, time.time() - t0, output

Expand Down
Loading