chore: align env_vars/env_vars_release defaults key order - #110
Merged
Conversation
Apply one canonical key order to the `defaults:` block of every config/build/env_vars*.yaml so the smoke and release profiles line up row-for-row and can be diffed side by side, and align the trailing comment column. No keys added or removed, no values changed, `overrides:` untouched. Provably a no-op: `defaults` is applied by plain dict iteration (PyAutoHands/autohands/env_config.py), so its order cannot affect the resolved environment. Refs PyAutoLabs/autolens_workspace#321
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The two env profiles under
config/build/—env_vars.yaml(thesmokeprofile driving the per-PR CI gate) andenv_vars_release.yaml(the release-fidelity profile) — listed the same keys in different orders, so they could not be read or diffed side by side. This applies one canonical key order to thedefaults:block of both, and aligns the trailing comment column.Canonical order (union of every key in use across the workspace, smoke-first):
No keys added or removed, no values changed, each key keeps its own comment text, and
overrides:is untouched (it is an ordered list of pattern rules where order is load-bearing).Provably a no-op.
defaultsis applied by plain dict iteration inPyAutoHands/autohands/env_config.py, so its order cannot affect the resolved environment.Scripts Changed
None — configuration only. No file under
scripts/is touched, so no notebook regeneration is involved.config/build/env_vars.yaml—defaults:reordered to the canonical order; comment column aligned.config/build/env_vars_release.yaml— same.Test Plan
resolve_clean()(PyAutoHands/autohands/validate_env_profiles.py). Identical — this is a strictly stronger check than a smoke run for a config-only change, since it proves every script's environment is byte-for-byte unchanged rather than sampling a subset.validate_env_profiles.pyverdict byte-identical tomain(no new errors or warnings).git diff --statcontains nothing butconfig/build/env_vars*.yaml.diffof the two profiles'defaults:blocks now shows only genuine value/comment differences, with keys lining up row-for-row.Part of a workspace-wide sweep across 10 repos. Refs PyAutoLabs/autolens_workspace#321.
Generated by the PyAutoLabs agent workflow.