ci: consume Heart's canonical arcticpy install instead of a local copy - #18
Merged
Merged
Conversation
The arcticpy recipe had drifted into four shell copies across the CTI repos with no single owner. Heart now owns it as a composite action; this repo drops its copy and asks for it. - .github/workflows/smoke_tests.yml passes `arcticpy: true`, so Heart's smoke-tests.yml runs install-arcticpy before this workspace's epilogue. - .github/scripts/smoke_install.sh loses the recipe, keeping only what is genuinely workspace-specific (the chain install and the autonerves re-pin). This also removes a silent cross-repo coupling: the epilogue's correctness depended on a `pip install --upgrade pip setuptools wheel` line in Heart's workflow, with nothing stating the dependency. - AGENTS.md: the documented recipe said "after numpy+cython" and omitted setuptools, which is a BUILD dependency that --no-build-isolation will not supply and that Python 3.12+ venvs no longer ship. It also omitted scipy and matplotlib, which arcticpy/read_noise.py imports at import time and which --no-deps suppresses — without them `import arcticpy` raises ModuleNotFoundError. Recipe corrected and verified against a clean build. Refs PyAutoLabs/PyAutoHeart#170 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018nDAxBEavkzb6Zkz1cYHef
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of PyAutoLabs/PyAutoHeart#170. Consumer leg — blocked on PyAutoLabs/PyAutoHeart#171 merging first (see Merge order below).
The arcticpy install recipe had drifted into four shell copies across the CTI repos with no single owner. PyAutoHeart now owns it as a composite action; this repo drops its copy.
Changes
.github/workflows/smoke_tests.ymlpassesarcticpy: true, so Heart'ssmoke-tests.ymlrunsinstall-arcticpybefore this workspace's epilogue..github/scripts/smoke_install.shloses the recipe, keeping only what is genuinely workspace-specific (the chain install and the autonerves re-pin).AGENTS.md— the documented recipe corrected.The coupling this removes
smoke_install.shdid not installsetuptools, and the task that prompted this described it as one runner-image change from breaking. That framing isn't accurate: Heart'ssmoke-tests.ymlrunspip install --upgrade pip setuptools wheelimmediately before invoking the epilogue, so setuptools was present.The real defect is weaker but still worth removing — the epilogue's correctness depended implicitly on a step in a different repository's workflow, with nothing on either side stating the dependency. Reordering or trimming that Heart step would have silently broken CTI smoke. The canonical action is self-contained, so the coupling is gone rather than merely documented.
AGENTS.md corrections
The recipe said "after numpy+cython" and omitted three things, each reproduced against a clean build of arcticpy 2.6:
setuptools— a build dependency--no-build-isolationwill not supply (it doesn't read arcticpy'sbuild-system.requires). Without it:BackendUnavailable: Cannot import 'setuptools.build_meta'. Python 3.12+ venvs no longer ship setuptools.scipyandmatplotlib— runtime imports ofarcticpy/read_noise.py, which__init__.pyimports.--no-depssuppresses them, so without them a successful build still fails atimport arcticpywithModuleNotFoundError.Merge order
Heart's PR must land first — this branch's
arcticpy: trueis only meaningful oncesmoke-tests.ymlon Heart'smainaccepts that input, and the action must exist there. Expect smoke CI here to fail until then.Verification
smoke_install.shpassesbash -n;smoke_tests.ymlparses as YAML. The end-to-end proof of the recipe itself (clean-container build, negative case, and a CTI trail with charge conserved) is in PyAutoLabs/PyAutoHeart#171, which owns the recipe now.Generated by Claude Code