docs: drop the resolved TEST_MODE rationale from the single-trap convention - #17
Merged
Merged
Conversation
…ention
The Conventions bullet justified keeping integration scripts single-trap by
citing the PYAUTO_TEST_MODE=2 bypass tying identical-prior ordered-trap models
at the prior medians ("a filed autofit issue; avoid the pattern here"). That
issue is fixed — PyAutoFit#1520 (merged 438f56fac) makes the bypass select a
deterministic assertion-valid point instead, at mode 2 and mode 3.
Only the rationale was stale, so only the rationale is removed; the single-trap
convention itself is left standing. Whether integration scripts still need to be
single-trap is a test-design call for a maintainer, not something a doc-truth
fix should decide — flagged on the issue so it can be revisited deliberately.
Refs PyAutoLabs/autocti_workspace#24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
## Conventionsbullet justified keeping integration scripts single-trap by citing thePYAUTO_TEST_MODE=2bypass tying identical-prior ordered-trap models at the prior medians — "a filed autofit issue; avoid the pattern here". That issue is fixed: PyAutoFit#1520 (merged438f56fac, 2026-08-24) makes the bypass select a deterministic assertion-valid point instead, at mode 2 and mode 3.Only the rationale is removed; the single-trap convention itself is left standing. Whether integration scripts still need to be single-trap is a test-design call for a maintainer, not something a doc-truth fix should decide — see below.
Scripts Changed
None —
AGENTS.mdprose only.smoke_tests.txtis untouched.Test Plan
grep -rni "assertion\|prior median\|tie at\|release_timescale" --include=*.mdover this repo returns no hits after the change.Worth a maintainer's decision
The convention now reads:
with no stated reason. If single-trap existed only to dodge the bypass crash, the constraint can now be dropped and multi-trap ordered models exercised here — which is arguably better coverage, since ordered traps are the realistic CTI case. If it also exists for runtime or simplicity, the bullet deserves that reason written in. I did not guess between those; deciding it is a separate change.
Companion PRs
Same issue, one PR per repo, no dependency between them:
AGENTS.md(the primary; carries the issue).skills/ac_fit_cti_model.md.Refs PyAutoLabs/autocti_workspace#24
Generated by the PyAutoLabs agent workflow.
Generated by Claude Code