Skip to content

mind: ship phase5-smoke-ordered-trap-scripts → complete - #298

Merged
Jammy2211 merged 1 commit into
mainfrom
claude/cti-ci-standardisation-phase-5-s52rxw
Aug 24, 2026
Merged

mind: ship phase5-smoke-ordered-trap-scripts → complete#298
Jammy2211 merged 1 commit into
mainfrom
claude/cti-ci-standardisation-phase-5-s52rxw

Conversation

@Jammy2211

Copy link
Copy Markdown
Collaborator

Closes out the last of the three CTI CI standardisation Phase 5 tasks. autocti_workspace#28 merged, issue #27 closed, smoke green on Python 3.12 and 3.13.

complete/2026/08/phase5-smoke-ordered-trap-scripts.md

CTI resurrection epic Phase 5. Smoke coverage for the ordered-trap modeling/start_here.py-class scripts, unblocked by PyAutoFit#1520 (438f56fac).

The prompt's premise did not hold. It said to "add them back to the workspace smoke_tests.txt" — there is no smoke_tests.txt, and never was. No .github/, no config/build/; git ls-files finds neither and nothing was ever deleted. So this created the repo's first CI rather than re-enabling coverage, which is why the task was larger than its "add lines to a file" sizing suggested.

It also closes pre-existing drift: Heart's config/repos.yaml lists autocti_workspace under workspaces, whose required checks are ["Smoke Tests", "Navigator Check"], with neither workflow present — a vacuous gate.

All nine scripts verified running bypassed against PyAutoFit 438f56fac (which is main HEAD, so "a PyAutoFit main containing that SHA" is satisfied by definition), with output/ cleared between every run. The fix is directly visible: the two identical-prior TrapInstantCapture models resolve to 0.14 and 1.68 — distinct and correctly ordered — instead of tying at the prior medians.

Three promoted, not nine. Measured the existing CTI smoke suite as a like-for-like baseline (20 s); all nine here cost ~522 s. The curated three run in 132 s cold, and CI confirmed it — 129 s on 3.12, ~123 s on 3.13. Full per-script timings live in the workspace's AGENTS.md so the next promotion starts from numbers.

Follow-ups the record carries

  • Navigator Check is still absent for autocti_workspace, though Heart lists it as required. Deliberately out of scope here.
  • Heart's local smoke runner table (smoke: in config/repos.yaml) has no autocti entry, and its import_names map has no PyAutoCTI.
  • The autocti_workspace_test ## Conventions "single-trap" question is left open for a human, as intended.

Generated files

active.md, complete/index.md, dashboard.md, dashboard.html regenerated with the repo's tooling. lifecycle.py check and index --check both OK.

Note: the earlier refresh failure on PR #297 was a stale local PyAutoBrain checkout (three commits behind, missing PyAutoBrain#265) generating pages that CI — which uses Brain@main — then read as stale. Brain is now at main and the pages regenerate clean.


Generated by Claude Code

… → complete

CTI epic Phase 5. autocti_workspace#28 merged; smoke green on 3.12 and 3.13.

The prompt's premise did not hold: autocti_workspace has no smoke_tests.txt and
never had one — no .github/, no config/build/, nothing deleted in history. So
this created the repo's FIRST CI rather than re-enabling coverage, which is why
the task was larger than its "add lines to a file" sizing. It also closes
pre-existing drift: PyAutoHeart/config/repos.yaml already lists the repo under
`workspaces`, whose required checks are "Smoke Tests" + "Navigator Check", with
neither workflow present.

All nine modeling/start_here.py-class scripts verified running bypassed against
PyAutoFit 438f56fac (main HEAD), output/ cleared between every run. The fix is
visible in the output: the two identical-prior traps resolve to 0.14 and 1.68,
distinct and correctly ordered, instead of tying at the prior medians.

Promoted a curated three (132s cold, CI measured 129s/123s) rather than all nine
(~522s), against a measured 20s baseline for the existing CTI smoke suite. Full
per-script timings recorded in the workspace's AGENTS.md.

Record also carries two follow-ups: Navigator Check is still absent for this
repo, and Heart's local smoke runner table has no autocti entry. The
autocti_workspace_test "single-trap" convention question is left open for a
human, as intended.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018nDAxBEavkzb6Zkz1cYHef
@Jammy2211
Jammy2211 merged commit b47bb6f into main Aug 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants