mind: ship phase5-smoke-ordered-trap-scripts → complete - #298
Merged
Conversation
… → complete CTI epic Phase 5. autocti_workspace#28 merged; smoke green on 3.12 and 3.13. The prompt's premise did not hold: autocti_workspace has no smoke_tests.txt and never had one — no .github/, no config/build/, nothing deleted in history. So this created the repo's FIRST CI rather than re-enabling coverage, which is why the task was larger than its "add lines to a file" sizing. It also closes pre-existing drift: PyAutoHeart/config/repos.yaml already lists the repo under `workspaces`, whose required checks are "Smoke Tests" + "Navigator Check", with neither workflow present. All nine modeling/start_here.py-class scripts verified running bypassed against PyAutoFit 438f56fac (main HEAD), output/ cleared between every run. The fix is visible in the output: the two identical-prior traps resolve to 0.14 and 1.68, distinct and correctly ordered, instead of tying at the prior medians. Promoted a curated three (132s cold, CI measured 129s/123s) rather than all nine (~522s), against a measured 20s baseline for the existing CTI smoke suite. Full per-script timings recorded in the workspace's AGENTS.md. Record also carries two follow-ups: Navigator Check is still absent for this repo, and Heart's local smoke runner table has no autocti entry. The autocti_workspace_test "single-trap" convention question is left open for a human, as intended. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018nDAxBEavkzb6Zkz1cYHef
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes out the last of the three CTI CI standardisation Phase 5 tasks. autocti_workspace#28 merged, issue #27 closed, smoke green on Python 3.12 and 3.13.
complete/2026/08/phase5-smoke-ordered-trap-scripts.mdCTI resurrection epic Phase 5. Smoke coverage for the ordered-trap
modeling/start_here.py-class scripts, unblocked by PyAutoFit#1520 (438f56fac).The prompt's premise did not hold. It said to "add them back to the workspace
smoke_tests.txt" — there is nosmoke_tests.txt, and never was. No.github/, noconfig/build/;git ls-filesfinds neither and nothing was ever deleted. So this created the repo's first CI rather than re-enabling coverage, which is why the task was larger than its "add lines to a file" sizing suggested.It also closes pre-existing drift: Heart's
config/repos.yamllists autocti_workspace underworkspaces, whose required checks are["Smoke Tests", "Navigator Check"], with neither workflow present — a vacuous gate.All nine scripts verified running bypassed against PyAutoFit
438f56fac(which ismainHEAD, so "a PyAutoFit main containing that SHA" is satisfied by definition), withoutput/cleared between every run. The fix is directly visible: the two identical-priorTrapInstantCapturemodels resolve to0.14and1.68— distinct and correctly ordered — instead of tying at the prior medians.Three promoted, not nine. Measured the existing CTI smoke suite as a like-for-like baseline (20 s); all nine here cost ~522 s. The curated three run in 132 s cold, and CI confirmed it — 129 s on 3.12, ~123 s on 3.13. Full per-script timings live in the workspace's
AGENTS.mdso the next promotion starts from numbers.Follow-ups the record carries
smoke:inconfig/repos.yaml) has no autocti entry, and itsimport_namesmap has no PyAutoCTI.## Conventions"single-trap" question is left open for a human, as intended.Generated files
active.md,complete/index.md,dashboard.md,dashboard.htmlregenerated with the repo's tooling.lifecycle.py checkandindex --checkboth OK.Note: the earlier
refreshfailure on PR #297 was a stale local PyAutoBrain checkout (three commits behind, missing PyAutoBrain#265) generating pages that CI — which uses Brain@main — then read as stale. Brain is now at main and the pages regenerate clean.Generated by Claude Code