prompt: record use_adjoint_scaling resolved (PyAutoArray#478) - #267
Merged
Conversation
Closes open item 1 on the pynufft removal record. The parameter and the adjoint_scaling attribute are removed from both remaining transformers and from the sole caller. Records where the factor actually did work, since the pynufft removal's notes left it ambiguous: TransformerDFT never applied it, the deleted TransformerNUFFTPyNUFFT did (Kaiser-Bessel compensation), and TransformerNUFFT applied it only until bd18a769 on 2026-05-22. Also records the user-facing caveat that the earlier investigation surfaced: results produced with TransformerNUFFT and use_adjoint_scaling =True before 2026-05-22 differ by 4 * N_y * N_x from anything regenerated today. That discrepancy dates from bd18a769, not from #478, and is worth raising with anyone holding interferometer results from that period.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes open item 1 on the pynufft removal record (
draft/maintenance/libraries/remove_pynufft_legacy_transformer.md). PyAutoLabs/PyAutoArray#478 removed theuse_adjoint_scalingparameter and theadjoint_scalingattribute from both remaining transformers and from the sole caller,Interferometer.apply_sparse_operator.The record previously said only that the flag "is now a no-op", which left ambiguous whether it had ever done anything. It had — and the distinction matters for anyone holding old results, so the history is now written down:
TransformerDFTTransformerNUFFTPyNUFFTTransformerNUFFTVerified numerically before removing anything:
TruevsFalsewas bit-identical (0.000e+00) on both classes, and nufftax matches the exact DFT at 1.562e-13 relative — the same figure before and after. Applying the factor would have been a 4096× error on a 32×32 grid, not a correction.The caveat this surfaced
Worth flagging beyond the record itself: anyone who used
TransformerNUFFTwithuse_adjoint_scaling=Truebefore 2026-05-22 has results that differ by4 * N_y * N_xfrom anything regenerated today. That discrepancy dates frombd18a769, not from #478 — it has been latent for three months. It is recorded in the prompt so it is not lost.Test Plan
python3 scripts/lifecycle.py check→lifecycle check: OKdashboard.md/dashboard.htmlregenerated viapyauto-brain intake --apply dashboard(149 prompts), not hand-editedapply_sparse_operator/ nufftax-adjoint incompatibility) is deliberately left open — it was not investigated hereGenerated by Claude Code