Fix subplot_fit_quick styling: arcsecond axes, source plane, code reuse - #550
Merged
Conversation
Rewrites both imaging and interferometer subplot_fit_quick to: - Use plot_array / plot_yx / _plot_source_plane from the standard pipeline for consistent axis labels, tick sizes, and colorbars - Wrap pre-computed numpy arrays as Array2D.no_mask so plot_array shows arcsecond coordinates (was showing pixel indices) - Reuse _plot_source_plane for the source panel (was missing for imaging, using raw imshow for interferometer) - Remove the custom _quick_imshow / _to_native_np helpers that bypassed the plotting pipeline entirely Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the subplot_fit_quick rendering for both imaging and interferometer:
Array2D.no_mask(pixel_scales=..., origin=...)soplot_arrayshows arcsecond coordinates instead of pixel indices_plot_source_plane(was missing/broken, now shows parametric or pixelized source correctly)plot_array/plot_yx/subplots/tight_layoutfrom the standard pipeline, matching axis labels, tick sizes, colorbars, and layout of the fullsubplot_fit_quick_imshow,_to_native_np,_quick_imshow_interf,_to_native_np_interfare gone; replaced by_slim_to_array2dwhich wraps numpy arrays with geometry forplot_arrayAPI Changes
None — same functions, same output filenames.
Test Plan
pytest test_autolens/🤖 Generated with Claude Code