chore(pre_build): drop the dead VERSION var; record the README-pin resolution (#155) - #174
Merged
Merged
Conversation
…solution Phase 4 task 4 of the build-chain campaign (#155) resolved the orphaned README version pins by REMOVING them (three surviving `<pkg> vX` lines) in favour of 'install the latest release' plus the version.minimum_library_version floor, which Heart's version_skew check actually verifies. pre_build.sh's VERSION string existed only to feed the README sed deleted in #158 — grep confirms nothing read it afterwards. Removed, with a note (and one next to the run_workspace call list) so no future session re-adds a bump: an unowned pin is what went ~2 months stale. docs/pre_build_failure_audit.md: §1.1 records the resolution and the rejected alternative (runner re-ownership = a new commit-to-main step of the kind #120/#121 removed, maintaining a string no gate reads). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XFnvcMxTMgKvfZmxame6WG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes out Phase 4 task 4 of the build-chain campaign (#155) on the Hands side.
pre_build.sh: theVERSION="$(date …).$MINOR_VERSION"string existed only to feed the README version-pin sed deleted in Delete pre_build's two dead failure-tolerant sites (audit step 1) #158.grep -n VERSIONconfirms nothing read it afterwards — removed, with a note so it is not resurrected.MINOR_VERSION(the release dispatch input) is untouched;bash -nclean.pre_build.shrun_workspace note +docs/pre_build_failure_audit.md§1 row and new §1.1: record that the pins were removed (autofit_workspace, autofit_workspace_test, autolens_workspace_test — PRs autofit_workspace#107, autofit_workspace_test#64, autolens_workspace_test#198) in favour of "install the latest release" + theversion.minimum_library_versionfloor, and that runner re-ownership was considered and rejected.No behaviour change: the deleted variable was unreferenced.