Remove pynufft following its removal from PyAutoArray - #583
Merged
Conversation
Drops the `TransformerNUFFTPyNUFFT` re-export from `autogalaxy/__init__.py`,
which would raise ImportError once PyAutoArray removes the class, and
removes `pynufft` from the `optional` extra.
Also updates the live documentation and citation surface, which described
PyNUFFT as the interferometer NUFFT backend: the installation pages now
point at `nufftax`, the feature overview names the backend actually in
use, and the citation lists (`files/citations.{md,tex,bib}`) cite nufftax
in its place.
`paper/` is deliberately untouched — those are published records of what
the software used at time of publication, not live documentation.
Must merge together with the PyAutoArray removal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to PyAutoLabs/PyAutoArray#475, which removes
TransformerNUFFTPyNUFFTand thepynufftdependency.Drops the
TransformerNUFFTPyNUFFTre-export fromautogalaxy/__init__.py:29— it would raiseImportErrorat import once PyAutoArray's removal lands — and removespynufftfrom theoptionalextra.Also updates the live documentation and citation surface, which still described PyNUFFT as the interferometer NUFFT backend. The installation pages actively instructed users to
pip install pynufft; they now point atnufftax, the feature overview names the backend actually in use, and the citation lists cite nufftax in PyNUFFT's place (PyAutoGalaxy had no nufftax entry at all, so this adds@nufftaxand@finuffttofiles/citations.bib).paper/is deliberately untouched — those are published JOSS records of what the software used at time of publication, not live documentation.Merge order: this one first, then PyAutoLens, then PyAutoArray#475 last. Dropping a re-export is safe against an autoarray that still has the class, so main is never red.
API Changes
Breaking:
autogalaxy.TransformerNUFFTPyNUFFTis no longer re-exported (the class itself is removed upstream in PyAutoArray#475). Migration isautogalaxy.TransformerNUFFT, orautogalaxy.TransformerDFTwhere JAX is unavailable.pynufftis no longer an optional dependency.See full details below.
Test Plan
pytest test_autogalaxy— 1103 passed, 1 skipped against PyAutoArray'sclaude/remove-pynufft-6uwt2zbranch (Python 3.13)import autogalaxysucceeds;hasattr(ag, "TransformerNUFFTPyNUFFT")isFalsepynufftreferences remain outsidepaper/Full API Changes (for automation & release notes)
Removed
autogalaxy.TransformerNUFFTPyNUFFT— re-export of the class removed in PyAutoArray#475; replaced byautogalaxy.TransformerNUFFTpynufftfrom[project.optional-dependencies] optionalChanged Behaviour
Migration
transformer = ag.TransformerNUFFTPyNUFFT(uv_wavelengths=uv, real_space_mask=mask)transformer = ag.TransformerNUFFT(uv_wavelengths=uv, real_space_mask=mask)transformer = ag.TransformerDFT(uv_wavelengths=uv, real_space_mask=mask)Generated by Claude Code