Merge pull request #80 from PyAutoLabs/feature/review-inplace-tasks

fix: review faculty --task resolves in-place (no-worktree) tasks

Author: Jammy2211

agents/faculties/review/AGENTS.md

@@ -40,8 +40,9 @@ produced by the reviewing agent (the session or subagent consulting this
 faculty) following the procedure below — mirroring how vitals' script reads
 Heart and the agent reasons over the verdict.
 
-1. `review.sh` (→ `_review.py`, stdlib-only) resolves the task worktree or
-   repo paths and emits, per repo: merge-base against `origin/main`, commits
+1. `review.sh` (→ `_review.py`, stdlib-only) resolves the task worktree —
+   or, for an in-place task with no worktree, the checkouts its `active.md`
+   `- repos:` block claims — or explicit repo paths and emits, per repo: merge-base against `origin/main`, commits
    ahead, diff stat, changed files, and risk flags (public-API-shaped paths,
    config/schema files, tests changed or not, generated files).
 2. The reviewing agent runs, over that surface: a **code review at high

agents/faculties/review/_review.py

@@ -18,6 +18,8 @@
 
 import argparse
 import json
+import os
+import re
 import subprocess
 import sys
 from pathlib import Path
@@ -75,11 +77,46 @@ def repo_surface(repo: Path) -> dict | None:
     }
 
 
+def in_place_repos(task: str) -> list[Path]:
+    """Checkouts claimed by an in-place task (worktree: none) in active.md.
+
+    Parses only the named task's `- repos:` block (`  - <Repo>: <branch>`
+    lines), never the bare 2-space claims other tooling reads — an in-place
+    entry lists its repos there and the checkouts live at the workspace root.
+    """
+    pyauto_root = Path(os.environ.get(
+        "PYAUTO_ROOT", Path.home() / "Code" / "PyAutoLabs"
+    ))
+    active = pyauto_root / "PyAutoMind" / "active.md"
+    if not active.exists():
+        return []
+    repos: list[Path] = []
+    in_entry = in_block = False
+    for line in active.read_text(errors="replace").splitlines():
+        if line.startswith("## "):
+            in_entry = line[3:].strip() == task
+            in_block = False
+            continue
+        if not in_entry:
+            continue
+        if line.strip() == "- repos:":
+            in_block = True
+            continue
+        if in_block:
+            m = re.match(r"^  - ([A-Za-z0-9_-]+):", line)
+            if m:
+                repos.append(pyauto_root / m.group(1))
+            else:
+                in_block = False
+    return [r for r in repos if (r / ".git").exists()]
+
+
 def resolve_repos(task: str | None, repos: list[str]) -> list[Path]:
     if task:
         root = WT_BASE / task
         if not root.is_dir():
-            return []
+            # No worktree — an in-place task; fall back to its active.md claims.
+            return in_place_repos(task)
         # Claimed repos are real directories (not symlinks) holding a .git
         # file/dir — worktree_create symlinks everything unclaimed.
         return sorted(

tests/test_review_inplace.py

@@ -0,0 +1,59 @@
+"""In-place (no-worktree) task resolution in the review faculty."""
+
+import subprocess
+import sys
+from pathlib import Path
+
+sys.path.insert(0, str(Path(__file__).resolve().parents[1] / "agents" / "faculties" / "review"))
+
+import _review  # noqa: E402
+
+ACTIVE = """\
+# Active Tasks
+
+## other-task
+- worktree: ~/Code/PyAutoLabs-wt/other-task
+- repos:
+  - PyAutoArray: feature/other-task
+
+## my-inplace-task
+- issue: https://example/1
+- status: workspace-dev
+- worktree: none (in-place)
+- repos:
+  - repo_a: feature/my-inplace-task
+  - repo_b: feature/my-inplace-task
+
+## no-repos-task
+- repos:
+"""
+
+
+def make_root(tmp_path, monkeypatch):
+    (tmp_path / "PyAutoMind").mkdir()
+    (tmp_path / "PyAutoMind" / "active.md").write_text(ACTIVE)
+    for name in ("repo_a", "repo_b"):
+        subprocess.run(["git", "init", "-q", str(tmp_path / name)], check=True)
+    monkeypatch.setenv("PYAUTO_ROOT", str(tmp_path))
+    return tmp_path
+
+
+def test_in_place_repos_reads_only_the_named_tasks_block(tmp_path, monkeypatch):
+    root = make_root(tmp_path, monkeypatch)
+    repos = _review.in_place_repos("my-inplace-task")
+    assert repos == [root / "repo_a", root / "repo_b"]
+
+
+def test_in_place_repos_skips_missing_checkouts_and_unknown_tasks(tmp_path, monkeypatch):
+    make_root(tmp_path, monkeypatch)
+    # other-task claims PyAutoArray, which has no checkout under this root.
+    assert _review.in_place_repos("other-task") == []
+    assert _review.in_place_repos("nonexistent") == []
+    assert _review.in_place_repos("no-repos-task") == []
+
+
+def test_resolve_repos_falls_back_when_no_worktree(tmp_path, monkeypatch):
+    root = make_root(tmp_path, monkeypatch)
+    monkeypatch.setattr(_review, "WT_BASE", tmp_path / "no-such-wt-base")
+    repos = _review.resolve_repos("my-inplace-task", [])
+    assert repos == [root / "repo_a", root / "repo_b"]