-
Notifications
You must be signed in to change notification settings - Fork 8
Feature/jax w tilde preload #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
565af3a
1ad6572
d185f9f
3cf259f
7979d3c
afb6e90
6145a2a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,9 +1,208 @@ | ||||||||||
| import json | ||||||||||
| import hashlib | ||||||||||
| from dataclasses import dataclass | ||||||||||
|
||||||||||
| from dataclasses import dataclass |
Copilot
AI
Jan 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docstring mentions rtol parameter but the function signature only has atol. Either remove rtol from the docstring or add it to the function signature.
| rtol, atol | |
| Tolerances for pixel scale comparisons (normally exact is fine | |
| atol | |
| Tolerance for pixel scale comparisons (normally exact is fine |
Copilot
AI
Jan 16, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The return type documentation is incorrect. The function always raises ValueError if incompatible (line 201), it never returns None. The docstring should state: "The loaded curvature_preload if compatible, otherwise raises ValueError." Also, raise_on_mismatch parameter is mentioned but doesn't exist.
| np.ndarray or None | |
| The loaded curvature_preload if compatible, otherwise None (unless raise_on_mismatch=True). | |
| np.ndarray | |
| The loaded curvature_preload if compatible, otherwise raises ValueError. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The character between 'INTERFEROMETER' and 'Computing' appears to be an en-dash (U+2013) rather than a hyphen-minus. For consistency with the rest of the codebase (e.g., line 489 in inversion_interferometer_util.py uses regular hyphen), this should use a standard hyphen-minus character.