chore: delete the defunct config/grids.yaml - #36
Merged
Conversation
The radial_minimum mapping in config/grids.yaml has not been read by any code since PyAutoGalaxy 025ac7ac "remove relocate_to_radial_minimum" (2025-10-15), which followed 82622f74 "remove grid relocate radial" (2025-04-03). The library default configs no longer ship a grids.yaml at all; only these downstream copies survived. Verified: zero .py hits for radial_minimum across PyAutoArray, PyAutoGalaxy, PyAutoLens, PyAutoCTI and PyAutoNerves, and zero hits in the installed venv. Profiles still evaluate finitely at exactly (0.0, 0.0) - the case the config used to guard is handled in code. Issue: PyAutoLabs/autolens_workspace#317 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WGnmAUuQwTSCnp8U5dD3ee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes
config/grids.yaml. Itsradial_minimum:mapping has not been read by any code since PyAutoGalaxy025ac7ac"remove relocate_to_radial_minimum" (2025-10-15), which followed82622f74"remove grid relocate radial" (2025-04-03). The library default configs (autoarray/config/,autogalaxy/config/) no longer ship agrids.yamlat all — only downstream copies survived, in 10 repos. This is part of a sweep removing all of them.Evidence gathered before deleting:
radial_minimum→ zero.pyhits across PyAutoArray, PyAutoGalaxy, PyAutoLens, PyAutoCTI, PyAutoNerves.radial_minimum→ zero hits anywhere in the installed venv."grids"config section; the only"grids"hits aredataset.gridsattribute lookups inautoarray/dataset/plot/imaging_plots.py.Scripts Changed
None — this PR deletes one config file and touches no
scripts/ornotebooks/.config/grids.yaml— deleted (unread since 2025-10-15)Test Plan
config/loads withgrids.yamlabsent —Isothermal.deflections_yx_2d_fromandSersic.image_2d_fromreturn all-finite values onGrid2D.uniform(shape_native=(20, 20), pixel_scales=0.1)radial_minimumused to guard — a coordinate at exactly(0.0, 0.0)— returns[0.0, 0.0]with no NaN, confirming the guard now lives in code rather than configgrids.yaml/radial_minimum/radiac_minimum: zero hitsCloses part of PyAutoLabs/autolens_workspace#317.
Generated by the PyAutoLabs agent workflow.