fix out on a limb auto continue when lang is FR#50
Open
xivsam wants to merge 1 commit intoPunishXIV:masterfrom
Open
fix out on a limb auto continue when lang is FR#50xivsam wants to merge 1 commit intoPunishXIV:masterfrom
xivsam wants to merge 1 commit intoPunishXIV:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
While it works fine directly in the gold saucer, it seems using the plugin on the Out on a Limb machine in a house does not auto continue while the game language is set to french. After testing/debugging it seems to work fine on all other languages, and it's due to a missing space of the object name in the room compared to the name in the datasheet that is used.
In PluginUI.cs
That shows the missing space:

So the fix proposed is to remove the spaces when comparing texts, maybe there's a more optimized way of doing it? (like using another item id / attribute in those data sheets for example idk)