Fix bug in get_enclosing_parameters #641
Merged
+3
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks @4lve |
Snowiiii
added a commit
that referenced
this pull request
Mar 19, 2025
* Populate biomes * actually fix multi noise sampler * actually they are all pass-through * fix serde error * prepare things * implement surface rules * fix max_y * fix terrain gen * make surface rules work * fix wrong biome coords * refactor height estimator to its own struct * implement surface estimation for surface rules * fix surface gen * some carve work * fix conflicts * more biomes work * fix biome map * refactor biome lookups * add unit tests * change from_block to from_chunk * not only lushcaves anymore * add more unit tests * add unit test * fix multi noise * Update proto_chunk.rs * fix biome map access * test badlands impl * fix badlands * fix some values * make it compile * Fix bug in get_enclosing_parameters (#641) * add badlands pillar and icebergs * fix clippy * fix clippy in test * Update README.md --------- Co-authored-by: kralverde <[email protected]> Co-authored-by: 4lve <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apperently it overrided the biome params for some reason
Testing
Please follow our Coding Guidelines