add Entity Saving/Reading #638
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kralverde
reviewed
Mar 17, 2025
| } | ||
|
|
||
| /// Used for Saving | ||
| pub trait DataToBytes |
There was a problem hiding this comment.
I think this should be named something more specific
| } | ||
|
|
||
| /// Used for Reading | ||
| pub trait BytesToData |
There was a problem hiding this comment.
I think this should be named something more specific
| } | ||
|
|
||
| #[async_trait] | ||
| impl ChunkSerializer for AnvilEntityFormat { |
There was a problem hiding this comment.
We probably want to create a brand new serializer instead of using the chunk serializer. ChunkFileManager can be probably renamed to FileManager. Then we can have FileManager<EntitySerializer> instead of ChunkSerializer
There was a problem hiding this comment.
Now sure what you mean, Do we want to fully replace ChunkSerializer ?. I mean its pretty different then FileManager and is a trait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Entity Saving/Reading
Testing
Please follow our Coding Guidelines