Partial Redstone

[4lve]

Description

This is a partial redstone implementation that makes a great base for implementing new blocks that use redstone. It also revamped the block state packets, neighbor updates and state updates

Testing

Please follow our Coding Guidelines

[Snowiiii]

Do you think you could add pressure plates in this PR as well?. This would require to make a system that sends an event when an entity collides with an blocks which we also would need for other things (e.g. Eggs, Snowballs, Enderperals...)

[Snowiiii]

I also think https://redstone.build/ is a great website to see and understand the existing Vanilla redstone logic

[OfficialKris]

Do you think you could add pressure plates in this PR as well?. This would require to make a system that sends an event when an entity collides with an blocks which we also would need for other things (e.g. Eggs, Snowballs, Enderperals...)

I think vanilla treats throwables differently than other entities. Since arrows get turned into a pickable item after they land they are slighly different than other throwables. That is why they can activate pressure plates. I think the algorithm for collisions is pretty simple from what I saw in the vanilla code. I think I can implement it in #523.

Redstone/pressureplace collisions would just be the same collision function just run on each tick rather than calculated on each tick and in between (think a snowball not colliding because it moved >1 block in-between ticks).

[4lve]

Do you think you could add pressure plates in this PR as well?. This would require to make a system that sends an event when an entity collides with an blocks which we also would need for other things (e.g. Eggs, Snowballs, Enderperals...)

Possibly after I'm done with everything else.

[4lve]

I also think https://redstone.build/ is a great website to see and understand the existing Vanilla redstone logic

I'm pretty familiar with redstone, the part I'm worried about is locationality

[DataM0del]

Suggested change

	fn is_state_solid(state: &BlockState, all_shapes: &Vec<CollisionShape>) -> bool {
	fn is_state_solid(state: &BlockState, all_shapes: &[CollisionShape]) -> bool {

[DataM0del]

(fixed)

[4lve]

Thanks, but I'm ignoring clippy for now

[kralverde]

I added some comments.

Also you're going to hate me but is there any possibility of adding tests for redstone? :p

[Snowiiii]

The first thing i got when started the server

$
  thread 'tokio-runtime-worker' panicked at /home/alex/Documents/Development/Rust/Pumpkin/pumpkin/src/world/mod.rs:1344:45:
                                                                                                                           called `Option::unwrap()` on a `None` value
            note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

My region folder was empty

[4lve]

The first thing i got when started the server

$
  thread 'tokio-runtime-worker' panicked at /home/alex/Documents/Development/Rust/Pumpkin/pumpkin/src/world/mod.rs:1344:45:
                                                                                                                           called `Option::unwrap()` on a `None` value
            note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

My region folder was empty

Try now