Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed block rotation on chest, signs, and furnaces #612

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

OfficialKris
Copy link
Contributor

@OfficialKris OfficialKris commented Mar 6, 2025

Description

Fixes rotation on chest, signs, and furnaces. Block properties are still not currently saved in world file.

Testing

Place sign on ground or on wall, sign and text faces you in correct direction
Place chest, faces you
Place furnace, faces you

TODO

  • Can place all signs (wall and standing)
  • Sign on ground follows allows angles
  • Correct angle calculated from player position to clicked position

Please follow our Coding Guidelines

@OfficialKris OfficialKris marked this pull request as draft March 6, 2025 03:35
@4lve
Copy link
Contributor

4lve commented Mar 6, 2025

I rewrote the whole property system, could you commit this into my repo instead or hold off until mine is merged to main? https://github.com/4lve/Pumpkin/tree/master

@OfficialKris
Copy link
Contributor Author

I rewrote the whole property system, could you commit this into my repo instead or hold off until mine is merged to main? https://github.com/4lve/Pumpkin/tree/master

Yes, I reworked all of the changes to your new system. Works great

@4lve
Copy link
Contributor

4lve commented Mar 11, 2025

I rewrote the whole property system, could you commit this into my repo instead or hold off until mine is merged to main? https://github.com/4lve/Pumpkin/tree/master

Yes, I reworked all of the changes to your new system. Works great

Nice, looks good

@Snowiiii
Copy link
Collaborator

@OfficialKris any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants