feat(player-data): Support saving and loading player NBT Data #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kralverde
requested changes
Mar 1, 2025
|
Why not move the nbt data into the hunger manager |
kralverde
requested changes
Mar 1, 2025
What if the program panics / crashes, and we can't handle leaving or the server shutting down? |
kralverde
approved these changes
Mar 5, 2025
|
I see you created |
HookWoods
force-pushed
the
feat/player-data-saving
branch
3 times, most recently
from
2010a10 to
f7f50fc
Compare
kralverde
requested changes
Mar 7, 2025
| let uuid_copy = *uuid; | ||
| let data_clone = data; | ||
|
|
||
| match tokio::spawn(async move { |
There was a problem hiding this comment.
Why are we spawning a tokio task here? No async code is used
|
|
||
| // Offload file I/O to a separate tokio task | ||
| let uuid_copy = *uuid; | ||
| let nbt = tokio::task::spawn_blocking(move || -> Result<NbtCompound, PlayerDataError> { |
There was a problem hiding this comment.
Why are we spawning a tokio task here? No async code is used
HookWoods
force-pushed
the
feat/player-data-saving
branch
from
5102893 to
39e551e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the must-have feature to save and load player NBT Data !
This code actually does:
This code also contains a rework of the experience packet and health packet with
tick_experienceandtick_health; this is needed with how NBT data are handled before player spawning in the world. Like that, we send experience, health, ... directly on the first player tick and send them when there is an update like before.I also added some data to NBT, like gamemode, or food, and impl them in the code to use them now instead of default data. Now the future part needed for this code is the implementation of other NBT values accessible from https://minecraft.wiki/w/Player.dat_format
Testing
I have tested to move on the map, give experience, change gamemode, ... stopping the server and joining again and all is working good. May need more test from others !
Please follow our Coding Guidelines