Open
Conversation
- Add HMACAuthMiddleware to verify HMAC-SHA256 signatures on requests - Validate timestamp to prevent replay attacks (5 minute window) - Exclude health check and docs endpoints from auth - Add HMAC_SECRET_KEY to config and .env.example
- Add generateHmacSignature utility function - Include HMAC_SECRET_KEY in environment config
- Test excluded paths bypass authentication - Test missing/invalid signature handling - Test timestamp expiration validation - Test valid signature acceptance
- Document signature generation algorithm - Add NestJS integration example - List validation rules and error responses
|
@Mosas2000 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Please fix failing workflow |
Fixes CI import error by using relative imports in package
Author
|
Done, fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds HMAC-SHA256 signature validation to secure inter-service communication between the NestJS backend and Python AI service.
Changes
FastAPI middleware validates X-HMAC-Signature and X-HMAC-Timestamp headers
NestJS utility generates signatures for outgoing requests
Requests with missing/invalid signatures return 403 Forbidden
5-minute timestamp window prevents replay attacks
Configuration
Set HMAC_SECRET_KEY in both services (generate with openssl rand -hex 32).
Closes #158