Feat/native asset & SAS Integretion#189
Merged
Cedarich merged 9 commits intoPulsefy:mainfrom Mar 29, 2026
Merged
Conversation
|
@Nabeelahh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@Nabeelahh fix failing workflow |
Contributor
Author
|
approve workflow sir |
Contributor
|
@Nabeelahh Kindly Run cargo fmt --all -- --check and fix workflow |
Contributor
Author
|
please approve workflow sir |
Cedarich
requested changes
Mar 29, 2026
Contributor
Cedarich
left a comment
Cedarich
left a comment
There was a problem hiding this comment.
Please remove changes from workflow files.
Solid implementation so far
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #155
Description:
The contract must seamlessly handle both Native XLM and Stellar Asset Contract (SAC) assets across all transaction flows. This ensures consistent behavior regardless of whether users interact with the system using native currency or tokenized assets like USDC or custom tokens.
Tasks:
Audit all
Address::transfercalls to confirm compatibility with both native and SAC assets.Implement standardized wrap/unwrap logic where necessary to ensure smooth Soroban interactions.
Build a comprehensive cross-asset test suite covering:
Changes made:
Contract correctly processes transfers for both native and SAC assets.
No edge-case failures when switching between asset types.
Wrap/unwrap logic is consistent and reliable.
Automated tests validate all flows across multiple asset types.