feat: implement reentrancy guard hardening across all vaults#439
Open
TheCreatorNode wants to merge 17 commits intoPulsefy:mainfrom
Open
feat: implement reentrancy guard hardening across all vaults#439TheCreatorNode wants to merge 17 commits intoPulsefy:mainfrom
TheCreatorNode wants to merge 17 commits intoPulsefy:mainfrom
Conversation
- Add shared reentrancy guard module using instance storage - Protect crowdfund_vault: deposit, withdraw, refund_contributors - Protect vesting-wallet: create_vesting, claim - Add ReentrancyDetected error variants to both contracts - Implement comprehensive test suites for reentrancy protection - Add documentation in REENTRANCY_GUARD.md Resolves Pulsefy#424 (150 points)
|
@TheCreatorNode Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Please fix workflow |
Author
Working on it |
- Changed &2000 to &1000 for amount and cliff_amount parameters - Ensures consistency with other tests in the file - Fixes test failure due to mismatched expected values
Contributor
|
Please resolve conflicts |
Author
|
@Cedarich Awaiting your review |
Contributor
|
Please address failing workflow |
Contributor
|
@TheCreatorNode fix clippy |
- Install missing @nestjs/cache-manager and cache-manager dependencies - Fix cache service async/await and return type issues - Simplify cache module to use memory store - All tests passing (130 tests) - Build successful - Lint passing
Author
awaiting your review |
Contributor
|
Clippy check still failing |
- Replace deprecated contractevent/topic system with env.events().publish() - Fix all event calls to use function-based API instead of struct-based - Remove testutils feature from production dependencies - Update symbol_short usage across all contracts - All contracts now build successfully for WASM target The event system has been completely modernized to work with Soroban SDK 21.x
Author
resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #424 (150 points)
Summary
Describe what changed and why.
Linked Issue
Closes #
Type of Change
Validation
Documentation
Checklist
feat/,fix/, ordocs/