Updated tests #24
Open
Updated tests #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sneurlax
reviewed
Nov 28, 2018
Collaborator
sneurlax
left a comment
sneurlax
left a comment
There was a problem hiding this comment.
This library hasn't been updated to the latest Monero version. Check the updated branches of the monerojs package
| if (result.hasOwnProperty('error')) { | ||
| if (result.hasOwnProperty('error')) { | ||
| if (result.error.code == -21) { | ||
| if (result.error.code === -21) { |
Author
|
I see. So we can close this pull request as this library use old Monero version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi PsychicCat,
I really impressed of this library and want to help you develop it. I've added some tests and parameters that will help to run test script on different environment.
Thank you!