Skip to content

fix(SendTileRectHandler): unable to place LogicSensors #3082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025

Conversation

LaoSparrow
Copy link
Contributor

Fixed unable to place LogicSensors (@LaoSparrow)

Maximum frameX should be 18 (inactivated=0, activated=18)
Maximum frameY should be 108
image

@LaoSparrow
Copy link
Contributor Author

LaoSparrow commented Mar 25, 2025

looks like clients only send TileRect with frameX 0 when these sensors are placed, is it better to be stricter (maxFrameX=0) or not?
ignore what i have said, they send both

I some how think there are more wrong matches/rules similar to this, anyone testing?

@LaoSparrow LaoSparrow marked this pull request as draft March 25, 2025 07:52
@LaoSparrow LaoSparrow marked this pull request as ready for review March 25, 2025 07:57
@hakusaro hakusaro requested a review from sgkoishi March 25, 2025 08:51
@hakusaro hakusaro enabled auto-merge May 14, 2025 09:47
@hakusaro hakusaro merged commit 10496e7 into Pryaxis:general-devel May 14, 2025
7 of 8 checks passed
@hakusaro
Copy link
Member

@LaoSparrow can you update the changelog on the wiki?

@LaoSparrow
Copy link
Contributor Author

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants