Skip to content

Fix/cicd build 129 - #101

Merged
Wilfred007 merged 4 commits into
Protocol-Guild:mainfrom
pope-h:fix/cicd-build-129
Mar 8, 2026
Merged

Fix/cicd build 129#101
Wilfred007 merged 4 commits into
Protocol-Guild:mainfrom
pope-h:fix/cicd-build-129

Conversation

@pope-h

@pope-h pope-h commented Mar 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix CI/CD pipeline build failures by:

  1. Making the GitHub Actions client-generation summary check resilient to log format differences.
  2. Fixing a frontend ESLint failure in Settings.tsx caused by passing an async function directly to onClick.
  3. Declaring the repo package manager for consistent tooling.

Changes

CI (GitHub Actions)

  • Update .github/workflows/build.yml so the “Check client generation summary” step:
    • Uses the last matched Failed: N value when present
    • Defaults to 0 when the pattern is missing
    • Avoids bash numeric comparison errors on empty values

Frontend (Lint)

  • Update frontend/src/pages/Settings.tsx:
    • Replace onClick={handleSave} with onClick={() => void handleSave()} to satisfy @typescript-eslint/no-misused-promises

Tooling

  • Add packageManager field to package.json to make package manager choice explicit.

How to verify

  • GitHub Actions: run the Build Project and Run Tests workflow on this PR.
  • Locally (optional):
    • cd frontend && npm ci --legacy-peer-deps
    • npm run lint

closes #100

@Wilfred007
Wilfred007 merged commit e87c518 into Protocol-Guild:main Mar 8, 2026
1 check passed
@pope-h
pope-h deleted the fix/cicd-build-129 branch March 25, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#129: Fix Cicd Pipeline Build

2 participants