Skip to content

Conversation

bspratt
Copy link
Member

@bspratt bspratt commented Oct 10, 2025

Reported by user Cristina

@bspratt bspratt requested a review from chambm October 10, 2025 15:23
@bspratt
Copy link
Member Author

bspratt commented Oct 10, 2025

Agilent reader test failure on TC isn't seen on my local build, trying again with the settings used on TC.

@chambm
Copy link
Member

chambm commented Oct 10, 2025

If you didn't see that failure I have to expect you didn't actually run that test. The failure looks correct: it's a neutral loss test file (judging from NL in the filename) which we previously didn't support, so it was empty, and now we support it, so now it's not empty. :)

Adding support for NL/NG isn't as simple as this though. I think we need to do something extra with the precursor or product element, I'm trying to remember/research now.

@chambm
Copy link
Member

chambm commented Oct 10, 2025

OK, it's like this in Thermo:
scan.set(MS_analyzer_scan_offset, scanInfo->analyzerScanOffset(), MS_m_z);

Did you see a way to get that offset in the Agilent API?

@bspratt
Copy link
Member Author

bspratt commented Oct 10, 2025

Yes, the test simply didn't run locally for some reason. I'll have to dive into my standard build batch file.

And yes, I missed the analyzer_scan_offset business, I'll see what I can find in the API.

@bspratt
Copy link
Member Author

bspratt commented Oct 10, 2025

OK, it's like this in Thermo: scan.set(MS_analyzer_scan_offset, scanInfo->analyzerScanOffset(), MS_m_z);

Did you see a way to get that offset in the Agilent API?

I don't see anything quite that convenient, but it should be knowable as the difference in either lower or upper bounds of Q1 and Q3 windows.

@bspratt bspratt marked this pull request as draft October 13, 2025 16:31
update Skyline's Spectrum Filter mechanism to handle Constant Neutral Loss / Gain scans, so we can extract chromatograms for various precursor/CNL combinations
@bspratt bspratt marked this pull request as ready for review October 15, 2025 18:27
@bspratt bspratt requested a review from nickshulman October 15, 2025 18:27
@bspratt bspratt changed the title Updated ProteoWizard's Agilent reader code to handle neutral loss/gain scan data Updated msconvert and Skyline to handle Agilent neutral loss/gain scan data Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants