Thermo Stellar SRM spectra improvements #3630
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nickshulman @brendanx67 if you could review the Skyline changes I'd appreciate it. I originally made the filter step in
FilterQ3SpectrumList
, but that required allocating new lists and Brendan suggested that might be a performance issue. So I moved it into the spectrum processing loop. It has to check the ReferenceEquals(Ms2ProductIons,) bit so it only applies to calls fromFilterQ3SpectrumList
.