Fix for feature finding #3358
Open
Fix for feature finding #3358
+55
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ries in an unconventional manner - entries don't have any fragments, just the precursor info. This tripped up the AutoManage code, specifically the use of TransitionSettings.Libraries.MinIonCount. Now we treat libraries with score type ScoreType.HARDKLOR_IDOTP as being immune to that particular filter.
brendanx67
requested changes
Feb 6, 2025
pwiz_tools/Skyline/FileUI/PeptideSearch/PeptideSearchResources.resx
Outdated
Show resolved
Hide resolved
pwiz_tools/Skyline/FileUI/PeptideSearch/ImportPeptideSearchDlg.cs
Outdated
Show resolved
Hide resolved
|
Also, there should be a test that confirms the new code works as expected. |
Right - a small modification to the existing test should take care of that, thanks |
…es.MinIonCount to a nonzero value to demonstrate that the fix works. Improve a couple of comments in the code per Brendan review. Tweak the language around "no features detected" per Brendan review.
|
@brendanx67 This should be good to go now. Probably worth backporting to release, too. |
|
Looks like your new code may cause a NRE in TestSrmTutorialLegacy. Check the TeamCity log for Tutorials and Perf tests. |
|
Yeah, it's hitting a null value for nodeGroup.LibInfo.ScoreType - certainly I can add a null check here, but would it be better to handle that at the LibInfo constructor and set it to ScoreType.UNKNOWN when null is proposed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature finding code uses spectral libraries in an unconventional manner - entries don't have any fragments, just the precursor info. This tripped up the AutoManage code, specifically the use of TransitionSettings.Libraries.MinIonCount. Now we treat libraries with score type ScoreType.HARDKLOR_IDOTP as being immune to that particular filter.
I can't help but wonder if there isn't a more general way to deal with this, though