-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add exports.types to package.json #131
base: master
Are you sure you want to change the base?
Conversation
What problem does this address? |
Hi @marijnh, I just added a description to the PR. Apologies for not doing so when submitting. |
Nice. Will this work both for CommonJS and ES module resolution? |
The rest of the specifications were correct, and this change won't affect CJS and ESM resolution, so all resolution paths will work correctly. I like to run |
I'm not seeing any problems when I import the ProseMirror modules from a TypeScript project that has |
This allows TypeScript to correctly resolve type imports when using Node's module resolution with:
"moduleResolution": "NodeNext"
, or"moduleResolution": "Node16"
Refs: